Attention is currently required from: laforge, pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email )

Change subject: sigtran: Make osmo_ss7_asp struct private ......................................................................

Patch Set 11: Code-Review+1

(1 comment)

File src/ipa.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645/comment/0cfb2e70_497f68... : PS3, Line 50: #i

Since they are in the same directory as the source file, hence included with "" it already becomes clear it's a private header imho.

right

That being said, I have no strong opinion, so if you really think another option is better, I'm fine to easily move all headers at the end in a follow-up commit when this gets merged, as suggested by osmith.

I think making it consistent either way would be useful (at least within one Osmocom project), e.g. all with _internal (as it seems Harald prefers) or all without internal and just relying on the location of the header file to indicate that they are internal. I'm fine with either, and I think this could be done after this patchset too so IMHO not worth blocking the patch over this.