Attention is currently required from: laforge, pespin.
Patch set 11:Code-Review +1
1 comment:
File src/ipa.c:
Since they are in the same directory as the source file, hence included with "" it already becomes clear it's a private header imho.
right
That being said, I have no strong opinion, so if you really think another option is better, I'm fine to easily move all headers at the end in a follow-up commit when this gets merged, as suggested by osmith.
I think making it consistent either way would be useful (at least within one Osmocom project), e.g. all with _internal (as it seems Harald prefers) or all without internal and just relying on the location of the header file to indicate that they are internal. I'm fine with either, and I think this could be done after this patchset too so IMHO not worth blocking the patch over this.
To view, visit change 38645. To unsubscribe, or for help writing mail filters, visit settings.