Attention is currently required from: pespin, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29361 )
Change subject: pcu_sock: check size of primitive ......................................................................
Patch Set 2:
(4 comments)
File include/osmocom/bsc/pcu_if.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/dd66f43b_0c3d8c58 PS2, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/583033d3_c0498f1f PS2, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited before that close parenthesis ')'
File src/osmo-bsc/pcu_sock.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/8666ecb5_4dafd5ed PS2, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \ do {} while (0) macros should not be semicolon terminated
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/5e7c14f0_983bc394 PS2, Line 459: } while(0); space required before the open parenthesis '('
-
Jenkins Builder