Attention is currently required from: pespin, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29361 ) Change subject: pcu_sock: check size of primitive ...................................................................... Patch Set 2: (4 comments) File include/osmocom/bsc/pcu_if.h: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/dd66f43b_0c3d8c58 PS2, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/583033d3_c0498f1f PS2, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited before that close parenthesis ')' File src/osmo-bsc/pcu_sock.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/8666ecb5_4dafd5ed PS2, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \ do {} while (0) macros should not be semicolon terminated Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/5e7c14f0_983bc394 PS2, Line 459: } while(0); space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I247c6f4b5a7a22d17a060a558c4ceb9221ca7351 Gerrit-Change-Number: 29361 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Sep 2022 09:39:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment