Attention is currently required from: pespin, dexter.

View Change

4 comments:

• File include/osmocom/bsc/pcu_if.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905):

    Patch Set #2, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) )

    space prohibited after that open parenthesis '('

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905):

    Patch Set #2, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) )

    space prohibited before that close parenthesis ')'

• File src/osmo-bsc/pcu_sock.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905):

    Patch Set #2, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \

    do {} while (0) macros should not be semicolon terminated

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-905):

    Patch Set #2, Line 459: } while(0);

    space required before the open parenthesis '('

To view, visit change 29361. To unsubscribe, or for help writing mail filters, visit settings.