Attention is currently required from: wbokslag.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/34169 )

Change subject: Added crypto support ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/crypto/tetra_crypto.c:

https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/8872d3dd_d9c6bc04 PS2, Line 249: // key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time), tmpdu_offset, ct_len); why is this (and similar lines below) commented-out in this patch? I'd suspect it would work just as well irrespective of crypto being introduced? So it looks like a logically separate change to me.

In general, we might benefit from introducing proper libosmocore log sub-systems in osmo-tetra, where each sub-system can have a differnt log level etc. - not asking you to work on this, just sharing general perspective.