Attention is currently required from: wbokslag.

Patch set 2:Code-Review +1

View Change

1 comment:

• File src/crypto/tetra_crypto.c:

  • Patch Set #2, Line 249: // key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time), tmpdu_offset, ct_len);

    why is this (and similar lines below) commented-out in this patch? I'd suspect it would work just as well irrespective of crypto being introduced? So it looks like a logically separate change to me.

    In general, we might benefit from introducing proper libosmocore log sub-systems in osmo-tetra, where each sub-system can have a differnt log level etc. - not asking you to work on this, just sharing general perspective.

To view, visit change 34169. To unsubscribe, or for help writing mail filters, visit settings.