Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 9: Code-Review-1 (2 comments) Patchset: PS9: I retain my position that I don't understand why this change is made in the first place, and where it improves upon the existing code. "Not using metaclasses" is not something I understand as an improvement, and clearly the readability has also not improved. I'm also a bit dissatisfied by the fact that this is the first change you introduce as part of your work on this task. It's not a functional change or anything that adds a feature, but it's a change that is mostly cosmetic and alters the existing code to be more to your personal preference without rendering a [AFAICT, and apparently fixeria agrees] clear advantage. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39741/comment/6f7d2351_753b426c?usp=em… : PS9, Line 37: class ConfigurableParameter: why is the new ConfugirableParameter not an ABC anymore? Can it be used directly, without further inheriting from it? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:57:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes