Attention is currently required from: neels.
Patch set 9:Code-Review -1
2 comments:
Patchset:
I retain my position that I don't understand why this change is made in the first place, and where it improves upon the existing code. "Not using metaclasses" is not something I understand as an improvement, and clearly the readability has also not improved.
I'm also a bit dissatisfied by the fact that this is the first change you introduce as part of your work on this task. It's not a functional change or anything that adds a feature, but it's a change that is mostly cosmetic and alters the existing code to be more to your personal preference without rendering a [AFAICT, and apparently fixeria agrees] clear advantage.
File pySim/esim/saip/personalization.py:
Patch Set #9, Line 37: class ConfigurableParameter:
why is the new ConfugirableParameter not an ABC anymore? Can it be used directly, without further inheriting from it?
To view, visit change 39741. To unsubscribe, or for help writing mail filters, visit settings.