Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29867 )

Change subject: osmux: Make sure RTP AMR feed to osmux is in octet-aligned mode ......................................................................

Patch Set 2:

(2 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/0696a7a6_be0a62ee PS2, Line 723: * boundaries. This function is used to convert between the two modes */

ack, especially if this is now public libosmo-mgcp API

The libosmo-mgcp is actually internal to osmo-mgw, and IMHO should be dropped completely and merged into osmo-mgw since it causes more trouble than benefits.

File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/11f64398_66bef826 PS2, Line 230: /* Osmux implementation works with AMR OA only, make sure we convert to it if needed: */

i would prefer having two patches, 1) the API change to use msgb and 2) adding the conversion to OA […]

Ack