Attention is currently required from: neels, dexter.

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #2, Line 723: * boundaries. This function is used to convert between the two modes */

    ack, especially if this is now public libosmo-mgcp API

    The libosmo-mgcp is actually internal to osmo-mgw, and IMHO should be dropped completely and merged into osmo-mgw since it causes more trouble than benefits.

• File src/libosmo-mgcp/mgcp_osmux.c:

  • Patch Set #2, Line 230: /* Osmux implementation works with AMR OA only, make sure we convert to it if needed: */

    i would prefer having two patches, 1) the API change to use msgb and 2) adding the conversion to OA […]

    Ack

To view, visit change 29867. To unsubscribe, or for help writing mail filters, visit settings.