Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31115 )

Change subject: trxcon: move AMR mode setting to l1sched_lchan_set_amr_cfg() ......................................................................

Patch Set 1:

(1 comment)

File src/host/trxcon/src/trxcon_fsm.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31115/comment/7f8ca305_51789386 PS1, Line 453: l1sched_lchan_set_amr_cfg(lchan,

you are missing calling "continue;" here if error is returned.

I think a better idea would be to validate AMR params before trying to apply them here. Otherwise we set lchan->tch_mode above, fail to apply the AMR params and thus do not set req->applied, which is weird.