Attention is currently required from: pespin.

View Change

1 comment:

• File src/host/trxcon/src/trxcon_fsm.c:

  • Patch Set #1, Line 453: l1sched_lchan_set_amr_cfg(lchan,

    you are missing calling "continue;" here if error is returned.

    I think a better idea would be to validate AMR params before trying to apply them here. Otherwise we set lchan->tch_mode above, fail to apply the AMR params and thus do not set req->applied, which is weird.

To view, visit change 31115. To unsubscribe, or for help writing mail filters, visit settings.