Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email )
Change subject: twjit: add underrun extension feature ......................................................................
Patch Set 2:
(3 comments)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/234ed583_004ff8ff... : PS1, Line 554: twjit->stats.underruns++;
In the new iteration of my patch, I added a comment explaining while this stats counter should not b […]
PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?
https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/53823e88_a25dbff5... : PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit)
I added an explanatory comment in the new iteration of my patch - is it good enough?
PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?
https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/401d686a_482c9976... : PS1, Line 671: if (read_sb_is_empty(twjit)) {
if (!read_sb_is_empty(twjit)) { […]
PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?
-
falconia