Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• File src/twjit.c:

  • Patch Set #1, Line 554: twjit->stats.underruns++;

    In the new iteration of my patch, I added a comment explaining while this stats counter should not b […]

    PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?

  • Patch Set #1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit)

    I added an explanatory comment in the new iteration of my patch - is it good enough?

    PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?

  • Patch Set #1, Line 671: if (read_sb_is_empty(twjit)) {

    if (!read_sb_is_empty(twjit)) { […]

    PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?

To view, visit change 42141. To unsubscribe, or for help writing mail filters, visit settings.