Attention is currently required from: fixeria, msuraev, dexter.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 )

Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8 ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/d75275bd_ef1abc6b PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav);

The usual approach would be grouping all test vectors into an array, and simply iterating over it in […]

that is true, and i wondered the same: why does this unit test not simply have an array with all test vectors.

But this patch's aim is to simply add test vectors, so this is fine as it is. Improving the way the regression test is organized would be a separate patch and semantically orthogonal to this patch.