Attention is currently required from: fixeria, msuraev, dexter.

Patch set 2:Code-Review +1

View Change

1 comment:

• File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c:

  • Patch Set #2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav);

    The usual approach would be grouping all test vectors into an array, and simply iterating over it in […]

    that is true, and i wondered the same: why does this unit test not simply have an array with all test vectors.

    But this patch's aim is to simply add test vectors, so this is fine as it is. Improving the way the regression test is organized would be a separate patch and semantically orthogonal to this patch.

To view, visit change 31454. To unsubscribe, or for help writing mail filters, visit settings.