Attention is currently required from: fixeria, jolly, laforge, osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547?usp=email )

Change subject: asterisk: Introduce test TC_internal_call_momt ......................................................................

Patch Set 3:

(3 comments)

File asterisk/Asterisk_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547/comment/f90d06cb_64b2b... PS2, Line 103: type record CallParsComputed

maybe explain in the commit msg the reasoning for merging CallParsComputed to CallPars?

The reasoning is most of the stuff was not yet used, as I initially took what exited in SIP_Templates for reference 😊

So think of it as if it was not there before.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547/comment/36b3d6f6_d5a7a... PS2, Line 193: log2str(g_name & ": Received unexpected SIP Req message := ", sip_req));

maybe also print "vs exp :=" here, like in as_SIP_fail_resp?

ACK thanks, I forgot to add it while refactoring my patch prior submitting.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547/comment/e727b3bf_97ef5... PS2, Line 236: }; */

do you want to keep this?

I'll leave it for now, it may help in doing more fain-grained matching in the future, but we don't need it for now.