Attention is currently required from: fixeria, jolly, laforge, osmith.

View Change

3 comments:

• File asterisk/Asterisk_Tests.ttcn:

  • Patch Set #2, Line 103: type record CallParsComputed

    maybe explain in the commit msg the reasoning for merging CallParsComputed to CallPars?

    The reasoning is most of the stuff was not yet used, as I initially took what exited in SIP_Templates for reference 😊

    So think of it as if it was not there before.

  • Patch Set #2, Line 193: log2str(g_name & ": Received unexpected SIP Req message := ", sip_req));

    maybe also print "vs exp :=" here, like in as_SIP_fail_resp?

    ACK thanks, I forgot to add it while refactoring my patch prior submitting.

  • Patch Set #2, Line 236: }; */

    do you want to keep this?

    I'll leave it for now, it may help in doing more fain-grained matching in the future, but we don't need it for now.

To view, visit change 36547. To unsubscribe, or for help writing mail filters, visit settings.