Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )

Change subject: WIP: vty: Add check against sensible default value for Ny1 ......................................................................

Patch Set 9:

(2 comments)

File tests/nanobts_omlattr/nanobts_omlattr_test.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/577ed8cd_b305f504 PS9, Line 133: { .T = -3105, .default_val = GSM_NY1_DEFAULT, .val = NY1_TESTVAL, .unit = OSMO_TDEF_CUSTOM,

My understanding from the comments above is that you want to set Ny1 to have it applied in the attr_ […]

Ah I see now that you actually this this T3015 here because it's used when test calls the check_ny1 function.

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/bd8004c0_205e5851 PS9, Line 161: trx = talloc_zero(ctx, struct gsm_bts_trx); I think this test is missing a calling to osmo_tdefs_reset(net->T_defs);