Attention is currently required from: arehbein.

View Change

2 comments:

• File tests/nanobts_omlattr/nanobts_omlattr_test.c:

  • Patch Set #9, Line 133: { .T = -3105, .default_val = GSM_NY1_DEFAULT, .val = NY1_TESTVAL, .unit = OSMO_TDEF_CUSTOM,

    My understanding from the comments above is that you want to set Ny1 to have it applied in the attr_ […]

    Ah I see now that you actually this this T3015 here because it's used when test calls the check_ny1 function.

  • Patch Set #9, Line 161: trx = talloc_zero(ctx, struct gsm_bts_trx);

    I think this test is missing a calling to osmo_tdefs_reset(net->T_defs);

To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.