Attention is currently required from: laforge, pespin, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29475 )

Change subject: [RFC] fix gsm0808_sc_cfg <-> gsm48_mr_cfg conversion ......................................................................

Patch Set 2:

(2 comments)

File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/fffb715d_f470169e PS2, Line 1612: if (s_modes && ((s_modes & modes) == s_modes))

can it happen that s_modes is 0 here?

it is possible, for example some modes are disabled for HR, and some are completely disabled for GSM. This check makes sure we don't set an S bit when s_modes is empty.

https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/3706a808_7492bb4c PS2, Line 1635: if (!(s15_s0 & s_bit))

don't you need to "s15_s0 & (1<<s_bit)" here?

thanks, nice catch.