Attention is currently required from: laforge, pespin, dexter.

View Change

2 comments:

• File src/gsm/gsm0808_utils.c:

  • Patch Set #2, Line 1612: if (s_modes && ((s_modes & modes) == s_modes))

    can it happen that s_modes is 0 here?

    it is possible, for example some modes are disabled for HR,
    and some are completely disabled for GSM.
    This check makes sure we don't set an S bit when s_modes is empty.

  • Patch Set #2, Line 1635: if (!(s15_s0 & s_bit))

    don't you need to "s15_s0 & (1<<s_bit)" here?

    thanks, nice catch.

To view, visit change 29475. To unsubscribe, or for help writing mail filters, visit settings.