Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38001?usp=email ) Change subject: pySim-shell: print cardinfo hexstrings in lowercase ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: this smells a bit like: * we should make sure to never assign upper case strings to the 'identity' dict in the first place * we should possibly make hex-strings a first-class citizen, i.e. have a `class hexstr(str)` which then has a `def str(self)` that performs the lower-case conversion. This way every time somebody prints a hexstr, it should be implicitly converted to lowercase. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60 Gerrit-Change-Number: 38001 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 15:40:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No