Attention is currently required from: dexter.
View Change
1 comment:
Patchset:
Patch Set #2:
this smells a bit like:
- we should make sure to never assign upper case strings to the 'identity' dict in the first place
- we should possibly make hex-strings a first-class citizen, i.e. have a `class hexstr(str)` which then has a `def str(self)` that performs the lower-case conversion. This way every time somebody prints a hexstr, it should be implicitly converted to lowercase.
To view, visit change 38001. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60
Gerrit-Change-Number: 38001
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 15:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No