Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270?usp=email ) Change subject: vty: Allow setting cnlink msc/sgsn name ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/cnlink.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270/comment/1fe63258_f1072f01?u… : PS2, Line 237: osmo_fsm_inst_update_id_f_sanitize(cnlink->fi, '-', cnlink->name); in theory osmo_fsm_inst_update_id_f_sanitize could fail, more likely than the others below. Should we silently ignore such errors or at least log something? Also, if the function always unconditionally returns 0 without propagating errors, you might as well make it return void instead of int... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic557f20f40fec49ce2c83a73f6e5c8b027d57ef5 Gerrit-Change-Number: 40270 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:29:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No