Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270?usp=email )

Change subject: vty: Allow setting cnlink msc/sgsn name ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-hnbgw/cnlink.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270/comment/1fe63258_f1072f01?us... : PS2, Line 237: osmo_fsm_inst_update_id_f_sanitize(cnlink->fi, '-', cnlink->name); in theory osmo_fsm_inst_update_id_f_sanitize could fail, more likely than the others below. Should we silently ignore such errors or at least log something?

Also, if the function always unconditionally returns 0 without propagating errors, you might as well make it return void instead of int...