Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-hnbgw/cnlink.c:

  • Patch Set #2, Line 237: osmo_fsm_inst_update_id_f_sanitize(cnlink->fi, '-', cnlink->name);

    in theory osmo_fsm_inst_update_id_f_sanitize could fail, more likely than the others below. Should we silently ignore such errors or at least log something?

    Also, if the function always unconditionally returns 0 without propagating errors, you might as well make it return void instead of int...

To view, visit change 40270. To unsubscribe, or for help writing mail filters, visit settings.