Attention is currently required from: daniel, laforge, osmith, pespin.

neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email )

Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ......................................................................

Patch Set 9: Code-Review+2

(2 comments)

File src/libosmo-mgcp/mgcp_msg.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/d9ca525b_c631163f?usp=... : PS8, Line 39: LOGP(DLMGCP, LEVEL, "endpoint:%s " FMT, (PDATA) ? ((PDATA)->epname ? : "null-epname") : "null-pdata", ##ARGS)

I wouldn't expect pdata to be null at any time but fine anyway.

i agree, but every so often i ended up with bugs with segfaults where a null log would have helped

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/78646661_38a0b196?usp=... : PS4, Line 710: if (osmux_init(trunk) < 0) {

That means making even more changes in this commit, so no, I'll keep it there in here. […]

Done