Attention is currently required from: daniel, laforge, osmith, pespin.

Patch set 9:Code-Review +2

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_msg.c:

  • Patch Set #8, Line 39: LOGP(DLMGCP, LEVEL, "endpoint:%s " FMT, (PDATA) ? ((PDATA)->epname ? : "null-epname") : "null-pdata", ##ARGS)

    I wouldn't expect pdata to be null at any time but fine anyway.

    i agree, but every so often i ended up with bugs with segfaults where a null log would have helped

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #4, Line 710: if (osmux_init(trunk) < 0) {

    That means making even more changes in this commit, so no, I'll keep it there in here. […]

    Done

To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.