Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31025 ) Change subject: Introduce tundev API ...................................................................... Patch Set 11: Code-Review+1 (5 comments) File src/core/tun.c: https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/6868aad5_71b810d0 PS4, Line 73: *NULL Done https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/cef38624_43cfbaa7 PS4, Line 87: bu Done File src/core/tun.c: https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/61223f72_f6c88113 PS9, Line 184: NULL Ack https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/115eab24_a0ad07f6 PS9, Line 371: |= Ack File src/core/tun.c: https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/c9659243_fada0f59 PS11, Line 834: (tundev)->netns_name); \ the line below LOGTUN with additional arguments needs more indentation, same 3x below -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3463271666df1e85746fb7b06ec45a17024b8c53 Gerrit-Change-Number: 31025 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Jan 2023 08:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment