Attention is currently required from: laforge, pespin.

Patch set 11:Code-Review +1

View Change

5 comments:

• File src/core/tun.c:

  • Patch Set #4, Line 73: *NULL

    missing space

    Done

  • Patch Set #4, Line 87: bu

    by?

    Done

• File src/core/tun.c:

  • Patch Set #9, Line 184: NULL

    I don't plan to pass this from the API, since the ctx passed there is per tundev and may be expected […]

    Ack

  • Patch Set #9, Line 371: |=

    Yes this is expected, as per https://git.netfilter.org/libmnl/tree/examples/rtnl/rtnl-link-set. […]

    Ack

• File src/core/tun.c:

  • Patch Set #11, Line 834: (tundev)->netns_name); \

    the line below LOGTUN with additional arguments needs more indentation, same 3x below

To view, visit change 31025. To unsubscribe, or for help writing mail filters, visit settings.