Attention is currently required from: Hoernchen.

lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )

Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/75f5fc67_bd7... : PS1, Line 8:

The title literally says that "what was wrong" is "ccid:" and two named messages, so two ccid messag […]

You're fixing two messages which were wrong in different ways and had different problems. Also those changes are quiet important.

Please split up the commit in two commits:

One for the missing bProtocolNum / ccid_gen_parameters One for the wrong interrupt header in ccid_rdr_to_pc_hardware_error.