Attention is currently required from: Hoernchen.
Patch set 1:Code-Review -1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 8:
The title literally says that "what was wrong" is "ccid:" and two named messages, so two ccid messag […]
You're fixing two messages which were wrong in different ways and had different problems. Also those changes are quiet important.
Please split up the commit in two commits:
One for the missing bProtocolNum / ccid_gen_parameters
One for the wrong interrupt header in ccid_rdr_to_pc_hardware_error.
To view, visit change 42157. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4
Gerrit-Change-Number: 42157
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Comment-Date: Sat, 21 Feb 2026 14:55:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>