Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27047 )

Change subject: core/utils.h: make use of OSMO_LIKELY in OSMO_ASSERT ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: So the linter suggests the following:

include/osmocom/core/utils.h:113: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

I tried doing this, and got lots of compilation errors like:

logging.c:1430:9: error: expected ‘;’ before ‘tall_log_ctx’

The problem is that some OSMO_ASSERT statements in the code (not only in libosmocore) have no semicolon in the end.

I suggest to ignore this warning, as I see no easy solution to this.