Attention is currently required from: osmith, laforge, pespin.

1 comment:

Patchset:
- Patch Set #2:
  So the linter suggests the following:
```
  include/osmocom/core/utils.h:113: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
```
  I tried doing this, and got lots of compilation errors like:
```
  logging.c:1430:9: error: expected ‘;’ before ‘tall_log_ctx’
```
  The problem is that some OSMO_ASSERT statements in the code (not only in libosmocore) have no semicolon in the end.
  I suggest to ignore this warning, as I see no easy solution to this.

To view, visit change 27047. To unsubscribe, or for help writing mail filters, visit settings.