Attention is currently required from: laforge, keith, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )

Change subject: e1d: reconnect to osmo-e1d after connection loss ......................................................................

Patch Set 6:

(1 comment)

File src/input/e1d.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/dd39fe4c_b037c13c PS4, Line 123: if (bfd->list.next && bfd->list.next != LLIST_POISON1)

I always go through the whole patchset, fix all comments and then I push. […]

No, it doesn't, because osmo_fd_is_registered() can be costly, and in most ocassions you know if the fd is registered or not.

This check of bfd->list.next smells like something not thought enough and that can be simplified. Can't you guarantee that if fd >= 0 then it is for sure registered and hence can be unconditionally urnegistered in this code path?