Attention is currently required from: laforge, keith, dexter.

View Change

1 comment:

• File src/input/e1d.c:

  • Patch Set #4, Line 123: if (bfd->list.next && bfd->list.next != LLIST_POISON1)

    I always go through the whole patchset, fix all comments and then I push. […]

    No, it doesn't, because osmo_fd_is_registered() can be costly, and in most ocassions you know if the fd is registered or not.

    This check of bfd->list.next smells like something not thought enough and that can be simplified. Can't you guarantee that if fd >= 0 then it is for sure registered and hence can be unconditionally urnegistered in this code path?

To view, visit change 32374. To unsubscribe, or for help writing mail filters, visit settings.