[M] Change in libosmocore[master]: osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c - gerrit-log

22 Feb 2024

Attention is currently required from: daniel, laforge, pespin.

jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35910?usp=email )

Change subject: osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c
......................................................................

Patch Set 5:

(5 comments)

File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/35910/comment/e20d8aba_b6f8e318 
PS4, Line 327: 	if (osmo_fd_is_registered(&iofd->u.uring.connect_ofd))
...
  Again this is expensive! Should be removed (or
conditionally enabled through ifdef). Done

https://gerrit.osmocom.org/c/libosmocore/+/35910/comment/55d39734_396ee78c 
PS4, Line 341: 	if (osmo_fd_is_registered(&iofd->u.uring.connect_ofd))
...
  Again this is expensive! Should be removed (or
conditionally enabled through ifdef). Done

https://gerrit.osmocom.org/c/libosmocore/+/35910/comment/e133d13d_9d2543aa 
PS4, Line 398: 	if (osmo_fd_is_registered(&iofd->u.uring.connect_ofd))
...
  Again this is expensive! Should be removed (or
conditionally enabled through ifdef). Done

https://gerrit.osmocom.org/c/libosmocore/+/35910/comment/e4c73d86_6c93f43f 
PS4, Line 437: 	/* Read connection error. */
...
  Couldn't this also contain the first actual data
read after connecting (e.g. […] Done

https://gerrit.osmocom.org/c/libosmocore/+/35910/comment/7147d84f_75708d2f 
PS4, Line 498: 		/* Use a temporary osmo_fd which we can use to notify us once the
connection is established
...
  I am not sure this is correct. According to man2
connect, the way to go is: […] In case of an error (connection failed), both read
and write events become available. I did some tests that showed that clearly. Now I
removed the read event from the patch. An additional getsockopt() is not required here.
This is done by stream_cli already and should be done by any other user.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35910?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4eca9ea72beb0d6ea4d44cce81ed620033f07270
Gerrit-Change-Number: 35910
Gerrit-PatchSet: 5
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 22 Feb 2024 10:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-MessageType: comment