Attention is currently required from: daniel, laforge, pespin.

View Change

5 comments:

• File src/core/osmo_io_uring.c:

  • Patch Set #4, Line 327: if (osmo_fd_is_registered(&iofd->u.uring.connect_ofd))

    Again this is expensive! Should be removed (or conditionally enabled through ifdef).

    Done

  • Patch Set #4, Line 341: if (osmo_fd_is_registered(&iofd->u.uring.connect_ofd))

    Again this is expensive! Should be removed (or conditionally enabled through ifdef).

    Done

  • Patch Set #4, Line 398: if (osmo_fd_is_registered(&iofd->u.uring.connect_ofd))

    Again this is expensive! Should be removed (or conditionally enabled through ifdef).

    Done

  • Patch Set #4, Line 437: /* Read connection error. */

    Couldn't this also contain the first actual data read after connecting (e.g. […]

    Done

  • Patch Set #4, Line 498: /* Use a temporary osmo_fd which we can use to notify us once the connection is established

    I am not sure this is correct. According to man2 connect, the way to go is: […]

    In case of an error (connection failed), both read and write events become available. I did some tests that showed that clearly. Now I removed the read event from the patch. An additional getsockopt() is not required here. This is done by stream_cli already and should be done by any other user.

To view, visit change 35910. To unsubscribe, or for help writing mail filters, visit settings.