Attention is currently required from: arehbein, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 )
Change subject: libosmocore: Transition to use of 'telnet_init_default' ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Patchset:
PS4:
Forgot to say. the title for the commit is too generic, doesn't explain what they do. What about: […]
pespin, does this also need a TODO-RELEASE entry?
File src/vty/telnet_interface.c:
https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/d47d21c4_6c64511d PS4, Line 45: \ref ('\ref' is to reference files, not functions. we've been using it wrongly for some time. Could drop it while busy editing the line anyway:
... call telnet_init_default() once
https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API... )
https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/ba612e85_09edd4dd PS4, Line 96: \deprecated (interesting, i wasn't aware of the \deprecated cmd yet)
-
neels