Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email ) Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ...................................................................... Patch Set 1: (6 comments) File TODO-RELEASE: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/6ce9e944_f5261c4c PS1, Line 31: mgcp NEW API add struct struct mgcp_codec_param2, depreacte struct mgcp_codec_param 'depreacte' may be misspelled - perhaps 'deprecate'? File include/osmocom/mgcp_client/mgcp_client.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/6c6dadf3_718abc03 PS1, Line 139: bool param_present; /* Depreacted, please use codecs_param_present */ 'Depreacted' may be misspelled - perhaps 'Deprecated'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/5263e471_ab5d3b44 PS1, Line 140: struct mgcp_codec_param param; /* Depreacted, please use codecs_param */ 'Depreacted' may be misspelled - perhaps 'Deprecated'? File src/libosmo-mgcp-client/mgcp_client.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/4a87a0e7_786dde1a PS1, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n"); 'depreacted' may be misspelled - perhaps 'deprecated'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/61467063_e7d09f41 PS1, Line 1393: if (mgcp_msg->codecs[i] != CODEC_AMR_8000_1 && mgcp_msg->codecs[i] != CODEC_AMRWB_16000_1) suspect code indent for conditional statements (24, 35) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/79366499_46d24275 PS1, Line 1394: continue; Statements should start on a tabstop -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I50d737f3f3d45e4004c64101700a471fe75b3436 Gerrit-Change-Number: 34351 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 08 Sep 2023 14:59:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment