View Change

6 comments:

• File TODO-RELEASE:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920):

    Patch Set #1, Line 31: mgcp NEW API add struct struct mgcp_codec_param2, depreacte struct mgcp_codec_param

    'depreacte' may be misspelled - perhaps 'deprecate'?

• File include/osmocom/mgcp_client/mgcp_client.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920):

    Patch Set #1, Line 139: bool param_present; /* Depreacted, please use codecs_param_present */

    'Depreacted' may be misspelled - perhaps 'Deprecated'?

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920):

    Patch Set #1, Line 140: struct mgcp_codec_param param; /* Depreacted, please use codecs_param */

    'Depreacted' may be misspelled - perhaps 'Deprecated'?

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920):

    Patch Set #1, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n");

    'depreacted' may be misspelled - perhaps 'deprecated'?

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920):

    Patch Set #1, Line 1393: if (mgcp_msg->codecs[i] != CODEC_AMR_8000_1 && mgcp_msg->codecs[i] != CODEC_AMRWB_16000_1)

    suspect code indent for conditional statements (24, 35)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10920):

    Patch Set #1, Line 1394: continue;

    Statements should start on a tabstop

To view, visit change 34351. To unsubscribe, or for help writing mail filters, visit settings.