Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls ...................................................................... Patch Set 1: (29 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/bd9081a1_6a2e5fb0 PS1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE, GSM44068_ALLOC_HEADROOM, name); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/da7d76ca_023201c4 PS1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE, GSM44068_ALLOC_HEADROOM, name); please, no spaces at the start of a line File src/host/layer23/include/osmocom/bb/mobile/transaction.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b77e959c_d23480de PS1, Line 75: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */ 'seperate' may be misspelled - perhaps 'separate'? File src/host/layer23/src/mobile/gsm411_sms.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5b0fda21_e73c440d PS1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/68a1ede4_e07fd5cb PS1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) { please, no spaces at the start of a line File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/793eab65_fca6b0b5 PS1, Line 31: * If it comes avaiable, the establishment is performed and the U4 is entered. 'avaiable' may be misspelled - perhaps 'available'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/293fbff0_2a0edf29 PS1, Line 545: struct gsm48_uplink_release *ur = (struct gsm48_uplink_release *) msgb_put(msg, sizeof(*ur)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/4eaf8fe2_9d4b2b9f PS1, Line 545: struct gsm48_uplink_release *ur = (struct gsm48_uplink_release *) msgb_put(msg, sizeof(*ur)); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/0b6c939a_ae98a37c PS1, Line 549: gh->proto_discr = GSM48_PDISC_RR; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/68779e83_d9c3ce5b PS1, Line 549: gh->proto_discr = GSM48_PDISC_RR; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/02fe4002_39714356 PS1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/54f8e44c_086c229c PS1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ebbbc15c_c45ccc08 PS1, Line 551: ur->rr_cause = cause; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ad95be92_82937a54 PS1, Line 551: ur->rr_cause = cause; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b7d10ada_814a4bbd PS1, Line 691: /* Change to GROUP CALL ACTIVE (seperate link) state. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/6a758d03_9d6fefc2 PS1, Line 780: /* Set flag that we change to group receive mode after seperate link. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5d26883b_e9a84ed8 PS1, Line 821: /* Reset flag after we changed to group receive mode after seperate link. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b837f8b0_d1919a03 PS1, Line 832: LOG_GCC(trans, LOGL_INFO, "Ignoring release, because we released seperate link.\n"); 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/899b246f_13c4693e PS1, Line 859: /* Reset flag after we changed to group receive mode after seperate link. */ 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/df60528b_ddf7d4c3 PS1, Line 862: LOG_GCC(trans, LOGL_INFO, "Joined group call after releasing seperate link.\n"); 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/937aadb4_3b325086 PS1, Line 1208: vgcs_vty_notify(trans, "Answer\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/32ee0eb7_117cf96d PS1, Line 1208: vgcs_vty_notify(trans, "Answer\n"); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/daecb788_8f25125f PS1, Line 1234: vgcs_vty_notify(trans, "Timeout\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/99b2ecb8_f6aeeef1 PS1, Line 1234: vgcs_vty_notify(trans, "Timeout\n"); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/dcf45341_fadf2150 PS1, Line 1301: vgcs_vty_notify(trans, "Timeout\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/2b5d41f3_f7268dc2 PS1, Line 1301: vgcs_vty_notify(trans, "Timeout\n"); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/f5acf32f_160bd58f PS1, Line 1352: .name = "GROUP CALL ACTIVE seperate link (U2sl)", 'seperate' may be misspelled - perhaps 'separate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5d4005f5_1ef71632 PS1, Line 1496: /* Create transaction together with state machine and set inital states. */ 'inital' may be misspelled - perhaps 'initial'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/f6a82d22_b14cd1d6 PS1, Line 1873: } else { else is not generally useful after a break or return -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 21 Sep 2023 09:40:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment