29 comments:
File src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE, GSM44068_ALLOC_HEADROOM, name);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE, GSM44068_ALLOC_HEADROOM, name);
please, no spaces at the start of a line
File src/host/layer23/include/osmocom/bb/mobile/transaction.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 75: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */
'seperate' may be misspelled - perhaps 'separate'?
File src/host/layer23/src/mobile/gsm411_sms.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) {
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) {
please, no spaces at the start of a line
File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 31: * If it comes avaiable, the establishment is performed and the U4 is entered.
'avaiable' may be misspelled - perhaps 'available'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 545: struct gsm48_uplink_release *ur = (struct gsm48_uplink_release *) msgb_put(msg, sizeof(*ur));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 545: struct gsm48_uplink_release *ur = (struct gsm48_uplink_release *) msgb_put(msg, sizeof(*ur));
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 549: gh->proto_discr = GSM48_PDISC_RR;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 549: gh->proto_discr = GSM48_PDISC_RR;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 551: ur->rr_cause = cause;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 551: ur->rr_cause = cause;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 691: /* Change to GROUP CALL ACTIVE (seperate link) state. */
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 780: /* Set flag that we change to group receive mode after seperate link. */
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 821: /* Reset flag after we changed to group receive mode after seperate link. */
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 832: LOG_GCC(trans, LOGL_INFO, "Ignoring release, because we released seperate link.\n");
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 859: /* Reset flag after we changed to group receive mode after seperate link. */
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 862: LOG_GCC(trans, LOGL_INFO, "Joined group call after releasing seperate link.\n");
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1208: vgcs_vty_notify(trans, "Answer\n");
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1208: vgcs_vty_notify(trans, "Answer\n");
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1234: vgcs_vty_notify(trans, "Timeout\n");
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1234: vgcs_vty_notify(trans, "Timeout\n");
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1301: vgcs_vty_notify(trans, "Timeout\n");
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1301: vgcs_vty_notify(trans, "Timeout\n");
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1352: .name = "GROUP CALL ACTIVE seperate link (U2sl)",
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1496: /* Create transaction together with state machine and set inital states. */
'inital' may be misspelled - perhaps 'initial'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
Patch Set #1, Line 1873: } else {
else is not generally useful after a break or return
To view, visit change 34494. To unsubscribe, or for help writing mail filters, visit settings.