Attention is currently required from: neels, fixeria, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 )

Change subject: Add BTS setup ramping to prevent BSC overloading ......................................................................

Patch Set 9:

(6 comments)

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cb9d3e34_6251ad85 PS4, Line 1326: BTS_NR_STR

BTS_NR_STR should not be here anymore.

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/c662ddc4_033debc3 PS4, Line 3088: cfg_bsc_bts_setup_ramping_cmd,

What's wrong with spacing here? It was good before.

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/0676f052_d129bc0f PS4, Line 3100: bts-setup-ramping-step-interval

IMO, 'bts-setup-ramping' and 'step-interval' should be separate things, so in the VTY one could list […]

Good idea. Please do a follow-up patch after this commit has been merged.

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/8ef01550_f99f91f4 PS4, Line 3103: CMD_ATTR_IMMEDIATE)

Spacing again.

can we please have a linter job. I don't want to discuss any spaces or tabs in reviews anymore, except the linter job is marking it.

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/1cb8925f_e675ea0a PS4, Line 3112: cfg_bsc_bts_setup_ramping_step_size_cmd,

Again spacing/alignment problems.

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/0c1ab484_847f4c09 PS4, Line 3115: Set a step interval

Step size or step interval? Copy pasted.

Done