Attention is currently required from: neels, fixeria, pespin.

View Change

6 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #4, Line 1326: BTS_NR_STR

    BTS_NR_STR should not be here anymore.

    Done

  • Patch Set #4, Line 3088: cfg_bsc_bts_setup_ramping_cmd,

    What's wrong with spacing here? It was good before.

    Done

  • Patch Set #4, Line 3100: bts-setup-ramping-step-interval

    IMO, 'bts-setup-ramping' and 'step-interval' should be separate things, so in the VTY one could list […]

    Good idea. Please do a follow-up patch after this commit has been merged.

  • Patch Set #4, Line 3103: CMD_ATTR_IMMEDIATE)

    Spacing again.

    can we please have a linter job. I don't want to discuss any spaces or tabs in reviews anymore, except the linter job is marking it.

  • Patch Set #4, Line 3112: cfg_bsc_bts_setup_ramping_step_size_cmd,

    Again spacing/alignment problems.

    Done

  • Patch Set #4, Line 3115: Set a step interval

    Step size or step interval? Copy pasted.

    Done

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.