Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37838?usp=email ) Change subject: pySim-shell: fix CardKeyProvider for chv management commands ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37838/comment/5fb50fcd_164719e4?usp=em… : PS3, Line 868: verify_chv_parser.add_argument('PIN', nargs='?', type=is_decimal, Why are you moving positional arguments before the optional `--pin-nr`? It's not critical, but makes the patch a bit harder to read. It also brings inconsistency, because below you keep it under the `--pin-nr`. I guess this also affects argument order in the help message? https://gerrit.osmocom.org/c/pysim/+/37838/comment/f4d9ba02_bcb5f360?usp=em… : PS3, Line 902: change_chv_parser.add_argument('NEWPIN', nargs='?', type=is_decimal, You're breaking compatibility by changing the ordering here: currently it's `OLD NEW`, but your patch is changing it to `NEW OLD`. Let's keep the old (more logical, IMO) ordering to avoid breaking scripts for people. It's also inconsistent with `unblock_chv_parser`, where you have `PUK NEWPIN`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b56ac608e801c67ca53d337bdec9efa3f3817 Gerrit-Change-Number: 37838 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 19:57:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes