Attention is currently required from: dexter.

Patch set 3:Code-Review -1

View Change

2 comments:

• File pySim-shell.py:

  • Patch Set #3, Line 868: verify_chv_parser.add_argument('PIN', nargs='?', type=is_decimal,

    Why are you moving positional arguments before the optional `--pin-nr`? It's not critical, but makes the patch a bit harder to read. It also brings inconsistency, because below you keep it under the `--pin-nr`. I guess this also affects argument order in the help message?

  • Patch Set #3, Line 902: change_chv_parser.add_argument('NEWPIN', nargs='?', type=is_decimal,

    You're breaking compatibility by changing the ordering here: currently it's `OLD NEW`, but your patch is changing it to `NEW OLD`. Let's keep the old (more logical, IMO) ordering to avoid breaking scripts for people. It's also inconsistent with `unblock_chv_parser`, where you have `PUK NEWPIN`.

To view, visit change 37838. To unsubscribe, or for help writing mail filters, visit settings.