Attention is currently required from: pespin.
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32498 )
Change subject: ctrl: Add penalty time control ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/6620a835_662185ce PS1, Line 774: cmd->reply = talloc_asprintf(cmd, "%u", (bts->si_common.cell_ro_sel_par.penalty_time * 20) + 20);
can you document with a comment in wich units is this?
Ack
https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/40d4fb50_465c84fc PS1, Line 796: CTRL_CMD_DEFINE(bts_penalty_time, "penalty-time");
this looks really too generic ("bts.penalty-time"). […]
In comment or by renaming the penalty time to something like si3-penalty-time?
-
matanp