Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo-bsc/bts_ctrl.c:

  • Patch Set #1, Line 774: cmd->reply = talloc_asprintf(cmd, "%u", (bts->si_common.cell_ro_sel_par.penalty_time * 20) + 20);

    can you document with a comment in wich units is this?

    Ack

  • Patch Set #1, Line 796: CTRL_CMD_DEFINE(bts_penalty_time, "penalty-time");

    this looks really too generic ("bts.penalty-time"). […]

    In comment or by renaming the penalty time to something like si3-penalty-time?

To view, visit change 32498. To unsubscribe, or for help writing mail filters, visit settings.