Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30489 )

Change subject: llc: Proper separation of public & private APIs, Introduce llc_prim API ......................................................................

Patch Set 4: Code-Review+1

(8 comments)

Patchset:

PS4: None of my comments are critical, looks nice to me in general!

File include/osmocom/gprs/llc/llc_private.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/a517bc3a_c3484046 PS4, Line 36: OSMO_ Private API should not be using the 'OSMO_' prefix, right?

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/c253a562_481e6a6b PS4, Line 52: OSMO_ Same here: drop 'OSMO_' prefix.

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/9bd03185_f118e034 PS4, Line 78: OSMO_ Same here: drop 'OSMO_' prefix.

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/ab79c2ae_7cfbd677 PS4, Line 116: OSMO_ Same here: drop 'OSMO_' prefix.

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/0c604c51_8eaad7f7 PS4, Line 131: OSMO_ Same here: drop 'OSMO_' prefix.

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/ac4a4ffc_024946c4 PS4, Line 154: OSMO_ Same here: drop 'OSMO_' prefix.

File src/llc/llc.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/88e576f8_ec38b2e5 PS4, Line 203: &llme->lle[sapi] We may want to check-if/assert-that: sapi < ARRAY_SIZE(llme->lle).